[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 5301: Refactor mark events ... (issue 340650043 by address@hid
|
From: |
dak |
|
Subject: |
Re: Issue 5301: Refactor mark events ... (issue 340650043 by address@hidden) |
|
Date: |
Sun, 08 Apr 2018 23:18:44 -0700 |
https://codereview.appspot.com/340650043/diff/1/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
https://codereview.appspot.com/340650043/diff/1/ly/music-functions-init.ly#newcode833
ly/music-functions-init.ly:833: #(define-music-function (label)
((integer-or-markup?))
On 2018/04/08 23:34:01, thomasmorley651 wrote:
While you're on it, shouldn't the predicate be changed?
\mark #-1 full-fills integer-or-markup? but fails later in a
markup-command with
vector-ref. Same for \mark 1.0
We probably need something like
exact-index?
If exactness is required for indexing, we should fold it into the index?
predicate.
https://codereview.appspot.com/340650043/