[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Issue 5736: Fix input/regression/context-find-parent.ly (issue 559460043
From: |
nine . fierce . ballads |
Subject: |
Issue 5736: Fix input/regression/context-find-parent.ly (issue 559460043 by address@hidden) |
Date: |
Wed, 05 Feb 2020 13:30:35 -0800 |
Reviewers: ,
Message:
Regtest differences attached to the ticket are expected. I would
appreciate independent confirmation; is anyone interested in taking a
little time to understand the case? After that, I think it will make
sense to push this, since the code was reviewed last week and is just
enabled by this patch.
Description:
https://sourceforge.net/p/testlilyissues/issues/5736/
Enable the previously reviewed block of code required to fix this
regression test.
Please review this at https://codereview.appspot.com/559460043/
Affected files (+1, -2 lines):
M lily/context.cc
Index: lily/context.cc
diff --git a/lily/context.cc b/lily/context.cc
index
4fe1652751f9862908e75ce20642e6db3dc8fa1d..2a2871f32b5dbbd36afe4b0828e7e3d25138df0f
100644
--- a/lily/context.cc
+++ b/lily/context.cc
@@ -181,8 +181,7 @@ Context::unchecked_find (FindMode mode, Direction dir,
const bool allow_create = (mode != FIND_ONLY);
const bool allow_find = (mode != CREATE_ONLY);
- // TODO: Enabling this block will fix
input/regression/context-find-parent.ly.
- if (false && allow_find && (dir == CENTER))
+ if (allow_find && (dir == CENTER))
{
// Search everything in and below the scope of the current context first.
// Here is an example that depends on finding a context below.
- Issue 5736: Fix input/regression/context-find-parent.ly (issue 559460043 by address@hidden),
nine . fierce . ballads <=
- Re: Issue 5736: Fix input/regression/context-find-parent.ly (issue 559460043 by address@hidden), hanwenn, 2020/02/06
- Re: Issue 5736: Fix input/regression/context-find-parent.ly (issue 559460043 by address@hidden), nine . fierce . ballads, 2020/02/06
- Re: Issue 5736: Fix input/regression/context-find-parent.ly (issue 559460043 by address@hidden), hanwenn, 2020/02/07
- Re: Issue 5736: Fix input/regression/context-find-parent.ly (issue 559460043 by address@hidden), hanwenn, 2020/02/07
- Re: Issue 5736: Fix input/regression/context-find-parent.ly (issue 559460043 by address@hidden), nine . fierce . ballads, 2020/02/07