lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 5736: Fix input/regression/context-find-parent.ly (issue 55946


From: David Kastrup
Subject: Re: Issue 5736: Fix input/regression/context-find-parent.ly (issue 559460043 by address@hidden)
Date: Fri, 07 Feb 2020 15:44:42 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

address@hidden writes:

> LGTM
>
> nit: please use the commit SHA1 for referencing previous code. It is
> self-contained, and doesn't need the internet for understanding the
> context.

For referencing previous issues, we have so far used the issue number,
so that would be rather something to discuss on the list rather than as
a side note.

We have been able to transport the issue database across several
different systems, so the issue numbers have proven a comparatively
workable reference frame.  Commit ids work just in Git.

For information strictly related to a single commit, like when reverting
a commit, a commit id is certainly a good reference but at least in the
case of reverts, the issue number contained in the original commit
message is also present.

In addition, issue numbers tend to be associated with reports showing
the history and rationale behind a change and often giving extensive
other information like problem images.  That's something we cannot
attach to commits (or at least, this has not been attempted so far).

-- 
David Kastrup



reply via email to

[Prev in Thread] Current Thread [Next in Thread]