Re: Fix and align musicxml and input language "deutsch" (issue 547610043 by address@hidden)

[dak]

Reviewers: lemzwerg,

Message:
On 2020/02/09 22:08:11, lemzwerg wrote:
> LGTM
> 
>
https://codereview.appspot.com/547610043/diff/567190043/scm/define-note-names.scm
> File scm/define-note-names.scm (right):
> 
>
https://codereview.appspot.com/547610043/diff/567190043/scm/define-note-names.scm#newcode302
> scm/define-note-names.scm:302: (heh . ,(ly:make-pitch -1 6 SEMI-FLAT))
> What about providing an alias for the old name 'beh' for backward
compatibility?

I'd rather not since it so glaringly wrong.  All other names of kind
"-eh" are _lowered_ by a quarternote, but this one is raised.  Even if
you wanted to start it off b, it would have to be called bih (assuming
quarternote enharmonicity).

Description:
Fix and align musicxml and input language "deutsch"

Has commits:

In \language "deutsch" use b only to replace hes

The quartertone names should all be derived from h instead of b since
beh was being used inconsistently.


Fix deutsch language of musicxml2py

Use b only for hes and nothing else.  Also use asas and asah instead
of ases and aseh.

Please review this at https://codereview.appspot.com/547610043/

Affected files (+5, -3 lines):
  M python/musicexp.py
  M scm/define-note-names.scm


Index: python/musicexp.py
diff --git a/python/musicexp.py b/python/musicexp.py
index 
c8ff05288deb84f3c39924e78fd92295efff20d7..6daf583f0d834e29ae913afa521da7b0b6e081ce
 100644
--- a/python/musicexp.py
+++ b/python/musicexp.py
@@ -321,11 +321,13 @@ def pitch_nederlands (pitch):
 
 def pitch_english (pitch):
     str = pitch_generic (pitch, ['c', 'd', 'e', 'f', 'g', 'a', 'b'], ['f', 
'qf', 'qs', 's'])
-    return str.replace ('aes', 'as').replace ('ees', 'es')
+    return str
 
 def pitch_deutsch (pitch):
     str = pitch_generic (pitch, ['c', 'd', 'e', 'f', 'g', 'a', 'h'], ['es', 
'eh', 'ih', 'is'])
-    return str.replace ('hes', 'b').replace ('aes', 'as').replace ('ees', 'es')
+    if str == 'hes':
+        return 'b'
+    return str.replace ('aes', 'as').replace ('ase', 'asa').replace ('ees', 
'es')
 
 def pitch_norsk (pitch):
     return pitch_deutsch (pitch)
Index: scm/define-note-names.scm
diff --git a/scm/define-note-names.scm b/scm/define-note-names.scm
index 
461b78b939cade3a69cccaf14cfb21fa74c2e20a..16ecd72489b85addb582c84ae5199f2692f598e7
 100644
--- a/scm/define-note-names.scm
+++ b/scm/define-note-names.scm
@@ -299,7 +299,7 @@
                 (heses . ,(ly:make-pitch -1 6 DOUBLE-FLAT))
                 (heseh . ,(ly:make-pitch -1 6 THREE-Q-FLAT))
                 (b . ,(ly:make-pitch -1 6 FLAT))
-                (beh . ,(ly:make-pitch -1 6 SEMI-FLAT))
+                (heh . ,(ly:make-pitch -1 6 SEMI-FLAT))
                 (h . ,(ly:make-pitch -1 6 NATURAL))
                 (hih . ,(ly:make-pitch -1 6 SEMI-SHARP))
                 (his . ,(ly:make-pitch -1 6 SHARP))