Re: Fix and align musicxml and input language "deutsch" (issue 547610043 by address@hidden)

[torsten . haemmerle]

On 2020/02/11 20:54:19, dak wrote:
>
https://codereview.appspot.com/547610043/diff/557380043/python/musicexp.py
> File python/musicexp.py (right):
> 
>
https://codereview.appspot.com/547610043/diff/557380043/python/musicexp.py#newcode324
> python/musicexp.py:324: return str
> On 2020/02/11 20:39:14, Be-3 wrote:
> > Proposal:
> > keep 1st character and replace 'fq' by 'tq' in the suffix:
> > 
> >   return str[:1] + str[1:].replace ('fq', 'tq')
> 
> Your proposal does not work for sqs.  Did an independent fix, as I
have not seen
> your proposal in time.  Please test since this should also still make
it into
> 2.20.

Yep, I forgot about the quarter tone sharps.

I've now successfully tested your English solution with a complete set
of all notes ranging from c to b using all accidentals in quarter tone
steps from double-flat to double-sharp.

Having a quick look at the other languages, espanol import is still
completely missing out quarter tones, even if there are Spanish quarter
note names. And portugues is completely missing.


def pitch_espanol (pitch):
    str = pitch_generic (pitch, ['do', 're', 'mi', 'fa', 'sol', 'la',
'si'], ['b', 'cb', 'cs', 's'])
    return str.replace ('bc', 'tc').replace ('sc', 'tc')

and 

def pitch_portugues (pitch):
    str = pitch_generic (pitch, ['do', 're', 'mi', 'fa', 'sol', 'la',
'si'], ['b', 'bqt', 'sqt', 's'])
    return str.replace ('bbqt', 'btqt').replace ('ssqt', 'stqt')

would do the trick, tested with the complete set.

Torsten


https://codereview.appspot.com/547610043/