lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Special-case syntax error of duration before octave marks (issue 557


From: hanwenn
Subject: Re: Special-case syntax error of duration before octave marks (issue 557410043 by address@hidden)
Date: Tue, 11 Feb 2020 22:45:08 -0800

https://codereview.appspot.com/557410043/diff/545570043/lily/parser.yy
File lily/parser.yy (right):

https://codereview.appspot.com/557410043/diff/545570043/lily/parser.yy#newcode3676
lily/parser.yy:3676: | pitch exclamations questions octave_check
duration stray_quotes optional_rest post_events {
why can't this case be folded in to the preceding rule? Maybe this
comment says it already; if so an example would help.

https://codereview.appspot.com/557410043/diff/545570043/lily/parser.yy#newcode3706
lily/parser.yy:3706: parser->parser_error (@6, _ ("octave marks must
precede duration"));
add a comment that we sholudn't drop this error, even though this works
for users (I think we don't want that because it makes parsing .ly
harder for others.)

https://codereview.appspot.com/557410043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]