|
| From: | jonas . hahnfeld |
| Subject: | Re: Parse inline scheme using per-expression port (issue 557330043 by address@hidden) |
| Date: | Thu, 13 Feb 2020 03:02:59 -0800 |
https://codereview.appspot.com/557330043/diff/579310044/configure.ac
File configure.ac (left):
https://codereview.appspot.com/557330043/diff/579310044/configure.ac#oldcode42
configure.ac:42: GUILEv2=no
Is this meant to be part of this patch? I'm all in for requiring /
defaulting to Guile 2.2 once ready, but this should probably be
separate.
https://codereview.appspot.com/557330043/diff/579310044/lily/include/overlay-string-port.hh
File lily/include/overlay-string-port.hh (right):
https://codereview.appspot.com/557330043/diff/579310044/lily/include/overlay-string-port.hh#newcode50
lily/include/overlay-string-port.hh:50: {
Is there an advantage of having the implementation in the header file?
If not, I think this should go to the .cc file.
https://codereview.appspot.com/557330043/
| [Prev in Thread] | Current Thread | [Next in Thread] |