Re: Don't count terminating \0 in Source_file::length (issue 579310043 by address@hidden)

[dak]

https://codereview.appspot.com/579310043/diff/549550043/lily/source-file.cc
File lily/source-file.cc (right):

https://codereview.appspot.com/579310043/diff/549550043/lily/source-file.cc#newcode51
lily/source-file.cc:51: characters_.push_back ((char)c);
Frankly, this seems like C++ should offer something better for reading a
whole input file into a buffer (also it seems like the sort of thing
that would be needed on any non-random access file, not just standard
input).

https://codereview.appspot.com/579310043/