lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Don't count terminating \0 in Source_file::length (issue 579310043 b


From: hanwenn
Subject: Re: Don't count terminating \0 in Source_file::length (issue 579310043 by address@hidden)
Date: Fri, 14 Feb 2020 14:43:35 -0800

https://codereview.appspot.com/579310043/diff/561450043/lily/source-file.cc
File lily/source-file.cc (right):

https://codereview.appspot.com/579310043/diff/561450043/lily/source-file.cc#newcode137
lily/source-file.cc:137: data_ = string (&chars[0], chars.size ());
On 2020/02/14 22:40:51, dak wrote:
> gulp_file_to_string ?
> 
> That one apparently also does some kind of logging, so one should
check that
> using it does not lead to duplications in the log.

I prefer keeping the functionality unchanged. We'd print filenames twice
if we used gulp_file_to_string, because Includable_lexer::new_input also
prints [FILENAME .. ]

https://codereview.appspot.com/579310043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]