[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Simplify define-markup-[list-]command-internal, (issue 545590045 by
From: |
dak |
Subject: |
Re: Simplify define-markup-[list-]command-internal, (issue 545590045 by address@hidden) |
Date: |
Sun, 16 Feb 2020 12:51:27 -0800 |
On 2020/02/16 20:37:34, hanwenn wrote:
> David, this goes on top of https://codereview.appspot.com/555300043/
>
> maybe I am missing something, but the regtest completes successfully.
Why did
> you add this stuff?
To allow for making aliases etc. A markup command definition involves a
number of things. It registers with the markup macro, it creates a
make-...-markup command, it creates a ...-markup definition. So a bunch
of bindings need to get created. markup-lambda does not do all that.
What it does is register the signature.
So you can in effect do
(define-markup-command blah (markup-lambda ...)) (or use the respective
part of an existing markup function or have an autogenerated
markup-lambda definition)
and have all the required bits for putting a markup command into the
name space.
Is there a particular reason you want to see this functionality killed?
https://codereview.appspot.com/545590045/