Re: Staging broken.

[David Kastrup]

David Kastrup <address@hidden> writes:

> Hi, staging does not compile anymore.
>
> Making lily/out/keyword.o < cc
> Making lily/out/simple-spacer-scheme.o < cc
> Making lily/out/episema-engraver.o < cc
> Making lily/out/lyric-extender.o < cc
> Making lily/out/includable-lexer.o < cc
> Making lily/out/timing-translator.o < cc
> Making lily/out/pango-font.o < cc
> Making lily/out/part-combine-part-iterator.o < cc
> Making lily/out/horizontal-bracket.o < cc
> /tmp/lilypond-autobuild/lily/pango-font.cc: In member function
> 'Stencil Pango_font::pango_item_string_stencil(const PangoGlyphItem*)
> const':
> /tmp/lilypond-autobuild/lily/pango-font.cc:229:28: error: invalid use
> of incomplete type 'PangoFcFont' {aka 'struct _PangoFcFont'}
>   229 |   FcPattern *fcpat = fcfont->font_pattern;
>       |                            ^~
> In file included from /usr/include/pango-1.0/pango/pangoft2.h:29,
>                  from /tmp/lilypond-autobuild/lily/pango-font.cc:20:
> /usr/include/pango-1.0/pango/pangofc-font.h:47:16: note: forward declaration 
> of 'PangoFcFont' {aka 'struct _PangoFcFont'}
>    47 | typedef struct _PangoFcFont      PangoFcFont;
>       |                ^~~~~~~~~~~~
> Making lily/out/clef-engraver.o < cc
> Making lily/out/key-performer.o < cc
> make[1]: ***
> [/tmp/lilypond-autobuild/stepmake/stepmake/c++-rules.make:5:
> out/pango-font.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [/tmp/lilypond-autobuild/stepmake/stepmake/generic-targets.make:6: 
> all] Error 2
>
> I'll back out the Pango related commit and retry.  It is a bit of a
> puzzler to me how this could have passed testing.

Actually, both Pango related commits.  Turns out that the "Make Pango
>= 1.36 mandatory" commit is responsible, likely by throwing out
required tests/definitions, and it is my guess that the other Pango
commit depends on that.

Probably the tests forgot to reconfigure, and it is in the configuration
phase that the defines were removed.

-- 
David Kastrup