Re: Staging broken.

[David Kastrup]

James <address@hidden> writes:

> Hello,
>
> On 18.02.2020 11:59, David Kastrup wrote:
>> David Kastrup <address@hidden> writes:
>> 
>>> Hi, staging does not compile anymore.
>>> Making lily/out/keyword.o < cc
>>> Making lily/out/simple-spacer-scheme.o < cc
>>> Making lily/out/episema-engraver.o < cc
>>> Making lily/out/lyric-extender.o < cc
>>> Making lily/out/includable-lexer.o < cc
>>> Making lily/out/timing-translator.o < cc
>>> Making lily/out/pango-font.o < cc
>>> Making lily/out/part-combine-part-iterator.o < cc
>>> Making lily/out/horizontal-bracket.o < cc
>>> /tmp/lilypond-autobuild/lily/pango-font.cc: In member function
>>> 'Stencil Pango_font::pango_item_string_stencil(const PangoGlyphItem*)
>>> const':
>>> /tmp/lilypond-autobuild/lily/pango-font.cc:229:28: error: invalid use
>>> of incomplete type 'PangoFcFont' {aka 'struct _PangoFcFont'}
>>>   229 |   FcPattern *fcpat = fcfont->font_pattern;
>>>       |                            ^~
>>> In file included from /usr/include/pango-1.0/pango/pangoft2.h:29,
>>>                  from /tmp/lilypond-autobuild/lily/pango-font.cc:20:
>>> /usr/include/pango-1.0/pango/pangofc-font.h:47:16: note: forward
>>> declaration of 'PangoFcFont' {aka 'struct _PangoFcFont'}
>>>    47 | typedef struct _PangoFcFont      PangoFcFont;
>>>       |                ^~~~~~~~~~~~
>>> Making lily/out/clef-engraver.o < cc
>>> Making lily/out/key-performer.o < cc
>>> make[1]: ***
>>> [/tmp/lilypond-autobuild/stepmake/stepmake/c++-rules.make:5:
>>> out/pango-font.o] Error 1
>>> make[1]: *** Waiting for unfinished jobs....
>>> make: ***
>>> [/tmp/lilypond-autobuild/stepmake/stepmake/generic-targets.make:6: 
>>> all] Error 2
>>> I'll back out the Pango related commit and retry.  It is a bit of a
>>> puzzler to me how this could have passed testing.
>
> Actually if you look on the tracker you'll see that I wrote
>
> 'Passes make, make test-baseline, and a full make doc.'
>
> This is probably my fault misunderstanding what can and what cannot be
> 'tested' after 'configure' has been run.

Everything?

> For example, as far as I can remember/tell if I *.ac files are patched
> then when I run
>
> ./autogen.sh --noconfigure
> mkdir build
> cd build
> ../configure
> make
> make test-baseline
>
> and THEN I try to apply the diff, I get some 'error' about the file
> being newer (or something, I cannot recall without doing it) as when
> you run the patch tests you are not re-running autogen/configure.

Why would you not rerun autogen/configure?

The procedure for a patch would be

git apply --index xxxx.diff
./autogen.sh --noconf
cd build
../configure --enable-checking  # and/or other desired options
make clean test-clean doc-clean
CPU_COUNT=9 make -j9 # or whatever other options
CPU_COUNT=9 make -j9 check
CPU_COUNT=9 make -j9 doc

If you want to be sure to rerun configure with the same options, you can
use

../config.status --recheck

assuming that you still have the results from last run.

> I am not versed enough to probably articulate myself here, but anyway,
> I assumed that I could never patch any of the make/config files
> because they never get re-done for the workflow that I have been
> using.

Well, I have no idea what went wrong when you tried redoing them.  We
probably need to figure that out.  I think you already reported this but
got no response or helpful suggestions at that time.

> So sorry for that. Obviously I need some education here.

I think we just need to figure out where and when and why things went
off-rail.  It's probably something simple that should have been easy to
fix long ago if I or somebody else had bothered listening.  Sorry.

-- 
David Kastrup
My replies have a tendency to cause friction.  To help mitigating
damage, feel free to forward problematic posts to me adding a subject
like "timeout 1d" (for a suggested timeout of 1 day) or "offensive".