Re: Accept GUILE 2 without extra configure options (issue 569390043 by address@hidden)

[hanwenn]

On 2020/02/21 16:39:20, hahnjo wrote:
> On 2020/02/21 16:36:57, hanwenn wrote:
> > On 2020/02/21 16:02:14, hahnjo wrote:
> > > guile-config since 2.0 has the following comment:
> > > "This script has been deprecated. Just use pkg-config."
> > > 
> > > Mabye it makes sense to completely turn to pkg-config? My system
has $ ll
> > > /usr/lib/pkgconfig/guile-*
> > > -rw-r--r-- 1 root root 453 11. Jan 2019 
/usr/lib/pkgconfig/guile-1.8.pc
> > > -rw-r--r-- 1 root root 849 10. Jan 2019 
/usr/lib/pkgconfig/guile-2.0.pc
> > > -rw-r--r-- 1 root root 886 10. Jul 2019 
/usr/lib/pkgconfig/guile-2.2.pc
> > > 
> > > So this would also work for Guile 1.8 (which should either be
preferred as
> > David
> > > suggested or completely dropped; not sure if we're already there).
> > 
> > this is an excellent idea; see the latest patchset.
> > 
> > Unfortunately, 
> > 
> > [hanwen@localhost lilypond]$ make
> > Making lily/out/lilypond 
> > /usr/bin/ld: ./out/accidental-engraver.o: undefined reference to
symbol
> > mailto:
> > /usr/bin/ld: /usr/lib64/libpthread.so.0: error adding symbols: DSO
missing
> from
> > command line
> > collect2: error: ld returned 1 exit status
> > make[1]: *** [out/lilypond] Error 1
> > make: *** [all] Error 2
> > [hanwen@localhost lilypond]$ pkg-config --libs guile-1.8
> > -lguile
> 
> $ pkg-config --cflags guile-1.8
> -D_FORTIFY_SOURCE=2 -pthread

Done. (It's ugly to put CFLAGS into the LIBS variable, but it works)

https://codereview.appspot.com/569390043/