[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Cleanup lilypond-book source (issue 583570043 by address@hidden)
From: |
jonas . hahnfeld |
Subject: |
Cleanup lilypond-book source (issue 583570043 by address@hidden) |
Date: |
Mon, 24 Feb 2020 02:05:04 -0800 |
LGTM, thanks for the cleanup!
In the future we might even consider putting all the book_*.py files
into a directory / package. That should make it more natural to import
them.
https://codereview.appspot.com/583570043/diff/545630043/python/book_base_test.py
File python/book_base_test.py (right):
https://codereview.appspot.com/583570043/diff/545630043/python/book_base_test.py#newcode48
python/book_base_test.py:48: self.assertEqual(chunks[-2].line_number,
18)
I'd start counting from the beginning (ie, chunks[7]): When extending
the test in the future, we don't have to recount from the end.
https://codereview.appspot.com/583570043/
- Cleanup lilypond-book source (issue 583570043 by address@hidden),
jonas . hahnfeld <=