lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 5788: New French Beamimg Approach (issue 557500043 by address@


From: hanwenn
Subject: Re: Issue 5788: New French Beamimg Approach (issue 557500043 by address@hidden)
Date: Sun, 23 Feb 2020 22:44:39 -0800

LGTM

special thanks for your well reasoned and extensive commit message.

One thing to consider: since the mechanics are now very predictable,
maybe we can name the property in after its mechanics? ie.
french-correction -> stem-end-shorten or something?


https://codereview.appspot.com/557500043/diff/551490044/lily/include/beam.hh
File lily/include/beam.hh (right):

https://codereview.appspot.com/557500043/diff/551490044/lily/include/beam.hh#newcode36
lily/include/beam.hh:36: struct Beam_stem_length
Beam_stem_end ?

https://codereview.appspot.com/557500043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]