lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

#5703 Run scripts/auxiliar/fixcc.py imminent


From: David Kastrup
Subject: #5703 Run scripts/auxiliar/fixcc.py imminent
Date: Sat, 29 Feb 2020 02:36:10 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Hi, I've run scripts/auciliar/fixcc.py on the stable branch now.  So
that it is reasonably easy to cherry-pick new commits from master into
the stable branch, it would make sense doing that in staging/master as
well.  This is a common base heeding our previously established coding
style mostly.  As Han-Wen noted, it does not try establishing consistent
spacing around template arguments, possibly because it cannot completely
reliably distinguish them from comparisons without semantic analysis.

So this may well not be the last word on how we are going about
formatting.

When I actually do run scripts/auxiliar/fixcc.py, it is comparatively
likely that it will be sort-of a pain regarding having to rebase already
developed but not yet committed patches.  So holler if you think this is
a bad moment, or I'll likely go ahead on Monday: the countdown on #5703
was previously and I threatened I'd be pushing eventually.  That is
coming up soonish.

I've tried running fixscm as well right now.  In general, it's a good
idea, but there are some coding passages diverging from Emacs'
commenting conventions (; for end-of line comments, ;; for comments at
current indentation, ;;; for comments always starting at the left).  In
particular, there are a few comment blocks with single semicola that
turn into something awkward.  I don't think I am going to tamper with
this before the release, but I might try fixing those comments and then
doing an indentation branch on what happens to be the stable/2.20 and
master branches at a time shortly after the release.

Different issue, so will be done without a rush.  Nobody is really going
to sue us for the indentation ending up in the release.  I hope.

-- 
David Kastrup



reply via email to

[Prev in Thread] Current Thread [Next in Thread]