[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 5806: Tweak mf files to avoid FontForge internal overlap error
From: |
lemzwerg |
Subject: |
Re: Issue 5806: Tweak mf files to avoid FontForge internal overlap error (issue 571780043 by address@hidden) |
Date: |
Sat, 29 Feb 2020 09:23:39 -0800 |
Very nice, thanks! LGTM.
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-arrowheads.mf
File mf/feta-arrowheads.mf (right):
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-arrowheads.mf#newcode58
mf/feta-arrowheads.mf:58: y5 = 0;
Please use an indentation of 8 spaces for orthogonality.
We could later decide to reduce the indentation to two (or four) spaces
– which I like much better. However, this would be a lot of work and is
probably not worth the trouble.
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-numbers.mf
File mf/feta-numbers.mf (left):
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-numbers.mf#oldcode467
mf/feta-numbers.mf:467: ..tension 0.9.. {dir (alpha + 10)}z2r
indentation
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-numbers.mf
File mf/feta-numbers.mf (right):
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-numbers.mf#newcode467
mf/feta-numbers.mf:467: pata:= subpath (0.1, 5) of z1r{dir (beta)}
s/pata:=/pata :=/
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-numbers.mf#newcode493
mf/feta-numbers.mf:493: fill subpath (ta,length pata) of pata
space after comma
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-numbers.mf#newcode494
mf/feta-numbers.mf:494: .. reverse subpath (tb,length patb) of patb
indentation
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-numbers.mf#newcode750
mf/feta-numbers.mf:750: .. {dir (delta - 90)}z3r
indentation
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-numbers.mf#newcode793
mf/feta-numbers.mf:793: patb := z13l{dir (180 + beta)}
indentation
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-scripts.mf
File mf/feta-scripts.mf (left):
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-scripts.mf#oldcode999
mf/feta-scripts.mf:999: .. z2l
indentation
https://codereview.appspot.com/571780043/