[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 5806: Tweak mf files to avoid FontForge internal overlap error
|
From: |
torsten . haemmerle |
|
Subject: |
Re: Issue 5806: Tweak mf files to avoid FontForge internal overlap error (issue 571780043 by address@hidden) |
|
Date: |
Sat, 29 Feb 2020 20:33:28 -0800 |
Re-formatted: spaces inserted and strictly 8 char indentations.
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-arrowheads.mf
File mf/feta-arrowheads.mf (right):
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-arrowheads.mf#newcode58
mf/feta-arrowheads.mf:58: y5 = 0;
On 2020/02/29 17:23:39, lemzwerg wrote:
> Please use an indentation of 8 spaces for orthogonality.
>
> We could later decide to reduce the indentation to two (or four)
spaces – which
> I like much better. However, this would be a lot of work and is
probably not
> worth the trouble.
Done.
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-numbers.mf
File mf/feta-numbers.mf (left):
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-numbers.mf#oldcode467
mf/feta-numbers.mf:467: ..tension 0.9.. {dir (alpha + 10)}z2r
On 2020/02/29 17:23:40, lemzwerg wrote:
> indentation
Thta's the old code (left side).
Indentation changed to strictly 8 characters.
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-numbers.mf
File mf/feta-numbers.mf (right):
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-numbers.mf#newcode467
mf/feta-numbers.mf:467: pata:= subpath (0.1, 5) of z1r{dir (beta)}
On 2020/02/29 17:23:39, lemzwerg wrote:
> s/pata:=/pata :=/
Done.
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-numbers.mf#newcode493
mf/feta-numbers.mf:493: fill subpath (ta,length pata) of pata
On 2020/02/29 17:23:40, lemzwerg wrote:
> space after comma
Done.
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-numbers.mf#newcode494
mf/feta-numbers.mf:494: .. reverse subpath (tb,length patb) of patb
On 2020/02/29 17:23:40, lemzwerg wrote:
> indentation
Done.
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-numbers.mf#newcode750
mf/feta-numbers.mf:750: .. {dir (delta - 90)}z3r
On 2020/02/29 17:23:40, lemzwerg wrote:
> indentation
Done.
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-numbers.mf#newcode793
mf/feta-numbers.mf:793: patb := z13l{dir (180 + beta)}
On 2020/02/29 17:23:40, lemzwerg wrote:
> indentation
Done.
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-scripts.mf
File mf/feta-scripts.mf (left):
https://codereview.appspot.com/571780043/diff/549620043/mf/feta-scripts.mf#oldcode999
mf/feta-scripts.mf:999: .. z2l
On 2020/02/29 17:23:40, lemzwerg wrote:
> indentation
Yeah. But that's the old code on the left side.
Nevertheless, I've changed the indentation to 8 characters.
https://codereview.appspot.com/571780043/