[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: mf: use python scripting for generating Emmentaler fonts (issue 5535
|
From: |
hanwenn |
|
Subject: |
Re: mf: use python scripting for generating Emmentaler fonts (issue 553580043 by address@hidden) |
|
Date: |
Sat, 29 Feb 2020 14:31:30 -0800 |
https://codereview.appspot.com/553580043/diff/571780045/mf/GNUmakefile
File mf/GNUmakefile (right):
https://codereview.appspot.com/553580043/diff/571780045/mf/GNUmakefile#newcode130
mf/GNUmakefile:130: $(outdir)/emmentaler-brace.otf:
emmentaler-brace.fontforge.py $(outdir)/emmentaler-brace.otf-table \
On 2020/02/29 21:33:10, lemzwerg wrote:
> maybe break line to make it shorter...
Acknowledged.
https://codereview.appspot.com/553580043/diff/571780045/mf/emmentaler-brace.fontforge.py
File mf/emmentaler-brace.fontforge.py (right):
https://codereview.appspot.com/553580043/diff/571780045/mf/emmentaler-brace.fontforge.py#newcode1
mf/emmentaler-brace.fontforge.py:1: #!@FONTFORGE@
On 2020/02/29 21:33:11, lemzwerg wrote:
> Can we assume that FontForge's python support and is always enabled?
Shall we
> check this?
the FF page doesn't say that python is optional.
https://codereview.appspot.com/553580043/diff/571780045/mf/emmentaler-brace.fontforge.py#newcode6
mf/emmentaler-brace.fontforge.py:6: import fontforge
On 2020/02/29 21:33:11, lemzwerg wrote:
> importing 'fontforge' twice is correct? If yes, please add a comment.
Done.
https://codereview.appspot.com/553580043/diff/571780045/mf/gen-emmentaler.fontforge.py
File mf/gen-emmentaler.fontforge.py (right):
https://codereview.appspot.com/553580043/diff/571780045/mf/gen-emmentaler.fontforge.py#newcode63
mf/gen-emmentaler.fontforge.py:63: alphabet
="feta-alphabet%(design_size)d" % vars()
On 2020/02/29 21:33:11, lemzwerg wrote:
> whitespace
Done.
https://codereview.appspot.com/553580043/