lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix test target name in python/GNUmakefile (issue 581770043 by addre


From: nine . fierce . ballads
Subject: Re: Fix test target name in python/GNUmakefile (issue 581770043 by address@hidden)
Date: Sat, 07 Mar 2020 10:40:57 -0800

On 2020/03/07 17:49:55, hanwenn wrote:
> it's a sequence of 6 commmits, which you can inspect here: 
> 
>   https://github.com/hanwen/lilypond/pull/2 

Don't you think these two should be combined?  I don't see value in
leaving the first commit with an incorrect target name.

commit 37c6ba676f4722a4e5a7b9965b64d46eff5e0bb1
Author: Han-Wen Nienhuys <address@hidden>
Date:   Fri Mar 6 16:47:26 2020 +0100

    Fix test target name in python/GNUmakefile

commit 79a1f4de2ac6035bbedf0e49841581d21533d3b7
Author: Han-Wen Nienhuys <address@hidden>
Date:   Fri Mar 6 16:32:12 2020 +0100

    scripts/build: run self-test as part of 'check' suite.


https://codereview.appspot.com/581770043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]