lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix test target name in python/GNUmakefile (issue 581770043 by addre


From: Han-Wen Nienhuys
Subject: Re: Fix test target name in python/GNUmakefile (issue 581770043 by address@hidden)
Date: Wed, 11 Mar 2020 12:49:04 +0100

On Wed, Mar 11, 2020 at 11:16 AM <address@hidden> wrote:
>
>
> https://codereview.appspot.com/581770043/diff/563700043/scripts/build/GNUmakefile
> File scripts/build/GNUmakefile (right):
>
> https://codereview.appspot.com/581770043/diff/563700043/scripts/build/GNUmakefile#newcode19
> scripts/build/GNUmakefile:19: $(PYTHON) output-distance.py --test
> This is wrong in 2 regards:
> 1) This should be local-test as also discussed for python/

done.

> 2) output-distance.py is not copied over to the build tree, so my build
> fails. I think patchy didn't see this problem because it's only running

done.

> 'make test' and James skipped 'make check' for the last patchset because
> you wrote "This means you can't run a regression test between the state
> before and after this change." (which I think is not true; at least it
> worked for me).

I added backward compat code.

 http://codereview.appspot.com/563730043

> https://codereview.appspot.com/581770043/



-- 
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen



reply via email to

[Prev in Thread] Current Thread [Next in Thread]