[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix Windows resource to enable manifest (issue 551580044 by address@
From: |
trueroad |
Subject: |
Re: Fix Windows resource to enable manifest (issue 551580044 by address@hidden) |
Date: |
Wed, 11 Mar 2020 05:08:49 -0700 |
Reviewers: lemzwerg, Be-3, dak, thomasmorley651,
Message:
I've added changes.tely entry in Issue 5833.
This Issue 5828 became "push", but I would like to push this and Issue
5833 together.
If only this issue is pushed without Issue 5833, LilyPond for Windows
cannot handle some filenames.
I wait until Issue 5833 becomes "push".
Description:
Issue 5828: Fix Windows resource to enable manifest
A manifest file `lilypond.manifest` is specified
in resource file `lilypond.rc` for the Windows executables.
To specify the manifest, the definitions
`CREATEPROCESS_MANIFEST_RESOURCE_ID` and `RT_MANIFEST`
are required in the resource file.
However, the manifest was not activated
because the resource file did not include `winuser.h`
that contained the required definitions.
Threfore, Unicode filenames could not be used
because the manifest was not activated.
This commit adds the include file `winuser.h` to the resoruce file
and activates the manifest.
This allows LilyPond for Windows to use Unicode filenames.
Please review this at https://codereview.appspot.com/551580044/
Affected files (+1, -0 lines):
M lily/lilypond.rc.in
Index: lily/lilypond.rc.in
diff --git a/lily/lilypond.rc.in b/lily/lilypond.rc.in
index
05abd4d0d2fe96ce0e1407a8c3ebbe23167738b4..48d8a810a89b38a4b9651dce79c35cae16c34ce0
100644
--- a/lily/lilypond.rc.in
+++ b/lily/lilypond.rc.in
@@ -1,4 +1,5 @@
#include <winver.h>
+#include <winuser.h>
LilyPond ICON "@outdir@/lilypond.ico"
LY ICON "@outdir@/ly.ico"
- Fix Windows resource to enable manifest (issue 551580044 by address@hidden), lemzwerg, 2020/03/07
- Re: Fix Windows resource to enable manifest (issue 551580044 by address@hidden), torsten . haemmerle, 2020/03/08
- Re: Fix Windows resource to enable manifest (issue 551580044 by address@hidden), dak, 2020/03/08
- Re: Fix Windows resource to enable manifest (issue 551580044 by address@hidden), torsten . haemmerle, 2020/03/08
- Re: Fix Windows resource to enable manifest (issue 551580044 by address@hidden), thomasmorley65, 2020/03/08
- Re: Fix Windows resource to enable manifest (issue 551580044 by address@hidden), dak, 2020/03/08
- Re: Fix Windows resource to enable manifest (issue 551580044 by address@hidden),
trueroad <=