[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix test target name in python/GNUmakefile (issue 575790044 by addre
From: |
nine . fierce . ballads |
Subject: |
Re: Fix test target name in python/GNUmakefile (issue 575790044 by address@hidden) |
Date: |
Sat, 07 Mar 2020 15:21:52 -0800 |
On 2020/03/07 21:36:04, hahnjo wrote:
> On 2020/03/07 21:24:48, hanwenn wrote:
> > I don't care much what we call this, and we can certainly change
this, but
> > it's historically been called check.
>
> Yes, but 'check' for LilyPond also does the comparison to
test-baseline. As
> 'check' depends on 'test' I think we should put it there because the
unit tests
> should run in both cases.
I see both points, and I don't have a strong opinion which way you take
it as long as you don't dig up this historical garbage:
> The user must build the program before running the tests
That's a recipe for wasted effort and confusion. Thankfully, it does
not currently work that way.
https://codereview.appspot.com/575790044/
- Fix test target name in python/GNUmakefile (issue 575790044 by address@hidden), jonas . hahnfeld, 2020/03/07
- Re: Fix test target name in python/GNUmakefile (issue 575790044 by address@hidden), nine . fierce . ballads, 2020/03/07
- Re: Fix test target name in python/GNUmakefile (issue 575790044 by address@hidden), hanwenn, 2020/03/07
- Re: Fix test target name in python/GNUmakefile (issue 575790044 by address@hidden), jonas . hahnfeld, 2020/03/07
- Re: Fix test target name in python/GNUmakefile (issue 575790044 by address@hidden),
nine . fierce . ballads <=
- Re: Fix test target name in python/GNUmakefile (issue 575790044 by address@hidden), hanwenn, 2020/03/07
- Re: Fix test target name in python/GNUmakefile (issue 575790044 by address@hidden), jonas . hahnfeld, 2020/03/08