Re: Fix test target name in python/GNUmakefile (issue 575790044 by address@hidden)

[hanwenn]

On 2020/03/07 21:36:04, hahnjo wrote:
> On 2020/03/07 21:24:48, hanwenn wrote:
> > On 2020/03/07 19:23:13, Dan Eble wrote:
> > > On 2020/03/07 18:59:54, hahnjo wrote:
> > > > I think this is wrong. Instead 'make test' should recurse into
the
> > > > subdirectories.
> > > 
> > > Agreed.  That would be here in the top-level GNUMakefile.in:
> > > 
> > > test: test-pre
> > >   @echo 'To begin investigating regression-test crashes, use'
> > >   @echo
> > >   @echo '    grep sourcefilename `grep -L systems.texi
> > > out/lybook-testdb/*/*log|sed s/log/ly/g`'
> > >   @echo
> > >   $(MAKE) -C input/regression out=test lysdoc-gittxt lysdoc-test
> > >   $(MAKE) -C input/regression/midi out=test lysdoc-test
> > >   $(MAKE) -C input/regression/musicxml out=test lysdoc-test
> > >   $(MAKE) -C input/regression/abc2ly out=test lysdoc-test
> > >   $(MAKE) -C input/regression/lilypond-book out=test local-test
> > 
> > The target is called check. See here
> > 
> >
>
https://github.com/lilypond/lilypond/blob/825dd87d0b1b58e56d7c66ef1fc1dd672d913c84/stepmake/stepmake/generic-targets.make#L141
> > 
> > it was called like that because the GNU standards at
> > https://www.gnu.org/prep/standards/standards.html say 
> > 
> > 
> > ‘check’
> > Perform self-tests (if any). The user must build the program before
running
> the
> > tests, but need not install the program; you should write the
self-tests so
> that
> > they work when the program is built but not installed.
> > 
> > 
> > I don't care much what we call this, and we can certainly change
this, but
> it's
> > historically been called check.
> 
> Yes, but 'check' for LilyPond also does the comparison to
test-baseline. As
> 'check' depends on 'test' I think we should put it there because the
unit tests
> should run in both cases.

could you send a patch to demonstrate what you mean? I ran "make test",
but I don't think my unittest was run

https://codereview.appspot.com/575790044/