Re: -Werror

[Jonas Hahnfeld]

Am Montag, den 15.06.2020, 07:50 -0400 schrieb Dan Eble:
> Han-Wen proposed building with -Werror in a merge request.  What do you think?
> 
> I like -Werror, but I've only ever used it where there were very few (or one) 
> supported build environments, all of which were covered in CI.  A dimension 
> of the CI coverage was optimization level, which can change what the compiler 
> discovers.
> 
> We don't have that here, so we might regret turning warnings into errors all 
> at once.  How about we turn particular warnings into errors, starting with 
> narrowing conversions and printf formatting, and wait to see if anyone 
> reports problems?  (Am I being too conservative?)

As I'm not sure what this proposal is about, I'd like to express that
I'm not a fan of enabling -Werror in the default configuration. That's
a pain when using a newer compiler, and you'll eventually get there
when bisecting an old bug.

I'm much more in favor of enabling -Werror in CI because the setting is
pretty fixed. However this assumes that the compiler in Ubuntu 16.04
doesn't throw stupid warnings that we don't want to fix, and it makes
future upgrades of the CI system a bigger pain than without. Not
necessarily bad to fix warnings for the newer compiler version, but
could be daunting.

What we could do instead is making the warnings more prominently
available. GitLab offers Metrics Reports [1] that looks flexible enough
to present this kind of information. I don't have an implementation
ready though.

Jonas

1: https://docs.gitlab.com/ee/ci/metrics_reports.html

signature.asc
Description: This is a digitally signed message part