[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE : RE : [lwip-devel] Snmp changes
From: |
Frédéric BERNON |
Subject: |
RE : RE : [lwip-devel] Snmp changes |
Date: |
Tue, 3 Apr 2007 10:42:40 +0200 |
To be precise, "mib_" will be better, because there are in mib2.c, and other
struct seems to be prefix with it. But it's not matching with atentry,
attable_id... But, you can let it I think (or ask to Christiaan Simons?). If
you change something, is it possible you fix these minor warnings ?
src\core\snmp\mib2.c (3657) : warning: variable "lport" was set but never used
src\core\snmp\mib2.c (3657) : warning: variable "rport" was set but never used
src\core\snmp\msg_in.c (544) : warning: variable "np" was set but never used
Thank you if you can...
>The problem is that some editors don't break the line and you can't see
>anything beyond, say, 90 lines.
Someone always got a just editor??? :) Ok.
====================================
Frédéric BERNON
HYMATOM SA
Chef de projet informatique
Microsoft Certified Professional
Tél. : +33 (0)4-67-87-61-10
Fax. : +33 (0)4-67-70-85-44
Email : address@hidden
Web Site : http://www.hymatom.fr
====================================
P Avant d'imprimer, penser à l'environnement
-----Message d'origine-----
De : address@hidden [mailto:address@hidden De la part de Goldschmidt Simon
Envoyé : mardi 3 avril 2007 10:19
À : lwip-devel
Objet : RE : [lwip-devel] Snmp changes
> Ok. I just think is "strange" to only use "g_" prefix in this
> case (snmp_ is more in lwip style?). Is it something to
Ok, you're probably right about that. I only wanted to get rid of the warning.
And as I don't even know what than name 'at_node' stands for (I'm not even
using the snmp part), I didn't know a better name for it.
> define or add in the contrib.txt ? I also got a style
> question: there is some extra LF in some code. Is it to avoid
> to reach column 80 (or other)? Is there any rules to respect
Yes, I think.
> on that? I prefer to let editors do the "break" than do it
> manually, just because all editors don't do it with the same rules
The problem is that some editors don't break the line and you can't see
anything beyond, say, 90 lines.
_______________________________________________
lwip-devel mailing list
address@hidden http://lists.nongnu.org/mailman/listinfo/lwip-devel
Frédéric BERNON.vcf
Description: Frédéric BERNON.vcf