[lwip-devel] [bug #2595] loopif results in NULL reference for incoming TCP packets

[Frédéric Bernon]

Follow-up Comment #7, bug #2595 (project lwip):

Just, I also note some remarks in "local connection failed on loopif, race?"
(forum's thread March 30th 2007):

If you got a mem_malloc( sizeof( void *[2]))c error, the "r" pbuf is not
freed (and "one day" you will got a "not enough memory") Inside sys_timeout,
if you got a memp_malloc(MEMP_SYS_TIMEOUT) error, there is no way to know by
the caller is the timer is initialized (and to free any resources in this
case, and so "one day", you will got a "not enough memory"). 
Last, using a timer to communicate pbuf between two "contexts" (and in fact,
this is the same, tcpip_thread) seems a little strange...

So, things to do seems to be :

- add pbuf_free when "if( NULL == arg ) {" is true
- add a return type de sys_timeout, and check result to do a pbuf_free and a
mem_free.
- prehaps redesign with a mbox + a new thread (but, I don't think it's a good
idea)?


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?2595>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/