[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [task #7490] Add return value to sys_mbox_post
From: |
Jonathan Larmour |
Subject: |
[lwip-devel] [task #7490] Add return value to sys_mbox_post |
Date: |
Fri, 11 Jan 2008 09:59:08 +0000 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.12) Gecko/20070530 Fedora/1.5.0.12-1.fc5 Firefox/1.5.0.12 |
Follow-up Comment #36, task #7490 (project lwip):
I'm ok with the patch, although it would be easy to optimise the common case
where all the values will be the same (especially true for the default case,
and in cases where the underlying mbox does not support different sizes
anyway). So add something like:
#if ((DEFAULT_RAW_RECVMBOX_SIZE == DEFAULT_UDP_RECVMBOX_SIZE) &&
(DEFAULT_UDP_RECVMBOX_SIZE == DEFAULT_TCP_RECVMBOX_SIZE))
/* All values identical, so just choose one of them */
# define RECVMBOX_SIZE DEFAULT_TCP_RECVMBOX_SIZE
#else
# define RECVMBOX_SIZE size
#endif
And then surround the added elements of the patch with:
#if (RECVMBOX_SIZE == size)
...
#endif
Thoughts?
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/task/?7490>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/
- [lwip-devel] [task #7490] Add return value to sys_mbox_post, (continued)
- [lwip-devel] [task #7490] Add return value to sys_mbox_post, Frédéric Bernon, 2008/01/05
- [lwip-devel] [task #7490] Add return value to sys_mbox_post, Frédéric Bernon, 2008/01/05
- [lwip-devel] [task #7490] Add return value to sys_mbox_post, Frédéric Bernon, 2008/01/06
- [lwip-devel] [task #7490] Add return value to sys_mbox_post, Frédéric Bernon, 2008/01/06
- [lwip-devel] [task #7490] Add return value to sys_mbox_post, Frédéric Bernon, 2008/01/09
- [lwip-devel] [task #7490] Add return value to sys_mbox_post, Frédéric Bernon, 2008/01/09
- [lwip-devel] [task #7490] Add return value to sys_mbox_post, Jonathan Larmour, 2008/01/09
- [lwip-devel] [task #7490] Add return value to sys_mbox_post, Simon Goldschmidt, 2008/01/10
- [lwip-devel] [task #7490] Add return value to sys_mbox_post, Frédéric Bernon, 2008/01/10
- [lwip-devel] [task #7490] Add return value to sys_mbox_post, Frédéric Bernon, 2008/01/10
- [lwip-devel] [task #7490] Add return value to sys_mbox_post,
Jonathan Larmour <=
- [lwip-devel] [task #7490] Add return value to sys_mbox_post, Frédéric Bernon, 2008/01/11
- [lwip-devel] [task #7490] Add return value to sys_mbox_post, Jonathan Larmour, 2008/01/12
- [lwip-devel] [task #7490] Add return value to sys_mbox_post, Frédéric Bernon, 2008/01/12
- [lwip-devel] [task #7490] Add return value to sys_mbox_post, Frédéric Bernon, 2008/01/12
- [lwip-devel] [task #7490] Add return value to sys_mbox_post, Simon Goldschmidt, 2008/01/12
- [lwip-devel] [task #7490] Add return value to sys_mbox_post, Frédéric Bernon, 2008/01/12
- [lwip-devel] [task #7490] Add return value to sys_mbox_post, Frédéric Bernon, 2008/01/13
- [lwip-devel] [task #7490] Add return value to sys_mbox_post, Frédéric Bernon, 2008/01/13