RE: [lwip-devel] RE: [lwip-commits] contrib/apps/chargen chargen.c

[Bill Auerbach]

You're right, it was a stupid suggestion.

The comment about your compiler not supporting C++ comments doesn't fit if
it's a platform that could never use lwIP (because the processor doesn't or
couldn't support it or Ethernet for whatever reason).  Someone could say
"Well I use the PowerPC and am using a 1995 compiler...". Sure, ok.  I was
thinking if the device supports Ethernet, chances are its compiler would be
later and support C++ comments.  You're right though - it's not worth it.

I was unable to find when C++ comments were added to GCC.  I do know some
parts of the standard were added to the standard because they were widely
supported by compilers, and GCC tended to support proposed C features long
before other compiler authors did.  I was going to guess that C++ comments
were added in the early 90's if not late 80's.

Bill

>-----Original Message-----
>From: address@hidden
>[mailto:address@hidden On
>Behalf Of David Empson
>Sent: Thursday, January 07, 2010 5:16 PM
>To: lwip-devel
>Subject: Re: [lwip-devel] RE: [lwip-commits] contrib/apps/chargen
>chargen.c
>
>The problem is the key phrase: "most compilers", not "all compilers",
>and I
>think your timeline is way off.
>
>Of the three embedded compilers I'm using, one from 1999 (a port of gcc,
>possibly forked a few years earlier) doesn't support C++ comments, but
>I'm
>not using it with LWIP. I started using the others around 2003 and don't
>know their prior history.
>
>Since LWIP needs to support a wide range of platforms, and embedded
>compilers are highly variable, I believe LWIP should continue to target
>ANSI
>C 1990 as a minimum standard, and avoid the use of C99 features.
>
>Changing the comments to C++ style would require at a minimum a query to
>lwip-devel and lwip-users to see if this would affect anyone.
>
>----- Original Message -----
>From: "Bill Auerbach" <address@hidden>
>To: "'lwip-devel'" <address@hidden>
>Sent: Friday, January 08, 2010 3:37 AM
>Subject: [lwip-devel] RE: [lwip-commits] contrib/apps/chargen chargen.c
>
>
>> Simon,
>>
>> Why do this?  C++ comments have been included in the ANSI/ISO C
>standard
>> (C99) since 1999 and have been accepted by most compilers even up to
>10
>> years prior to that.
>>
>> I was even going to ask about providing a patch that changes all of
>the
>> single one line code comments to C++ style comments.  I find them
>easier
>> to
>> read and edit.
>>
>> Bill
>>
>>>-----Original Message-----
>>>From: address@hidden
>>>[mailto:address@hidden On
>>>Behalf Of Simon Goldschmidt
>>>Sent: Thursday, January 07, 2010 5:25 AM
>>>To: address@hidden
>>>Subject: [lwip-commits] contrib/apps/chargen chargen.c
>>>
>>>CVSROOT: /sources/lwip
>>>Module name: contrib
>>>Changes by: Simon Goldschmidt <goldsimon> 10/01/07 10:24:31
>>>
>>>Modified files:
>>> apps/chargen   : chargen.c
>>>
>>>Log message:
>>> Don't use C++ style comments
>>>
>>>CVSWeb URLs:
>>>http://cvs.savannah.gnu.org/viewcvs/contrib/apps/chargen/chargen.c?cvs
>ro
>>>ot=lwip&r1=1.8&r2=1.9
>
>
>
>_______________________________________________
>lwip-devel mailing list
>address@hidden
>http://lists.nongnu.org/mailman/listinfo/lwip-devel