[lwip-devel] [bug #54062] Inconsequent null pointer checks

[Simon Goldschmidt]

Follow-up Comment #4, bug #54062 (project lwip):

Well, you can't say it like that. You have to differentiate:
- things that can go wrong from external input must always be handled
gracefully to prevent DoS attacks. A DEBUGF output may be printed and an error
counter may be increased instead.

For the rest, handling is a bit unclear as
- LWIP_ASSERT can simply be disabled but the stack should continue to work, so
this rather covers errors in algorithms
- LWIP_ERROR _can_ be disabled, but it's not meant to. This covers checking
invalid input values and can be set to "halt" on error to catch errors during
development and be set to just return an error (without DEBUGF) in production
code.

However, the code has not been clean up everywhere to follow this rule.

Feel free to post patches. But I'm not sure if this is worth keeping this bug
entry open?

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?54062>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/