[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lwip-users] Stats and code readability
From: |
Marc Boucher |
Subject: |
Re: [lwip-users] Stats and code readability |
Date: |
Thu, 19 Jun 2003 03:53:00 -0400 |
User-agent: |
Mutt/1.5.1i |
On Thu, Jun 19, 2003 at 01:22:45AM +0200, Leon Woestenberg wrote:
> Hello Marc, others,
>
> sorry for my ignorance. I retract all comments I made, apologies.
No problem Leon.
> I would really welcome a way to be notified when a patch has
> been changed under Savannah.
Perhaps a suggestion could be sent to the Savannah folks.
> Logging in Savannah on a daily bases to see if any patches were
> added or changed is not a feasible way of working with tight
> schedules hanging around.
Agreed.
> Are you interested in CVS commit access?
I'll gladly accept the invitation if it offloads
you and other developers, while being careful not
to check-in anything too controversial. ;-)
> Either that, or please notify any patches on the mailing list.
>
> We have neglected the patches, but having said that, we are
> doing this all voluntarely.
I'm sure it was just a misunderstanding and that everyone really
appreciates the work done for the project. The progress made
in recent times has been great.
> Hope you will join the CVS team.
Count me in!
Cheers
Marc
>
> Regards,
>
> Leon.
>
>
>
>
> ----- Original Message -----
> From: "Marc Boucher" <address@hidden>
> To: "Mailing list for lwIP users" <address@hidden>
> Sent: Wednesday, June 18, 2003 9:14 PM
> Subject: Re: [lwip-users] Stats and code readability
>
>
> > On Wed, Jun 18, 2003 at 08:06:53PM +0200, Leon Woestenberg wrote:
> > >
> > > Hello,
> > >
> > > > I wouldn't mind these macros either, but perhaps the outstanding
> patches
> > > > should be merged first (or at least give a clear answer given to their
> > > > authors if they are rejected) before doing more pervasive changes to
> the
> > > code?
> > >
> > > I think most of the outstanding patches have become too old to merge in.
> >
> > I beg to differ and would like to kindly suggest that you (or fellow
> > maintainers) have another look at them.
> >
> > > Some of the patches were huge and I have taken pieces from them.
> > >
> > > In general, the outstanding patches are still there either because
> > > - no documentation
> > > - too huge (not split up)
> > > - too old
> >
> > Of the 13 presently open patches, 10 were submitted or refreshed
> > by myself quite recently (the majority just 5 days ago).
> > Most are small, low-risk, and self explanatory or imho adequately
> > commented. The largest is a set of critical fixes for PPP (and the
> > addition of support for testing under unix/linux) which I contributed
> > earlier.
> >
> > I would appreciate if most open patches could be applied
> > or declined/closed before significant changes are done
> > to the source. Having to repeatedly re-sync by hand
> > and resubmit patches is no fun job. This energy could
> > be much better spent doing constructive work.
> >
> > Thanks
> > Marc
> >
> >
> > _______________________________________________
> > lwip-users mailing list
> > address@hidden
> > http://mail.nongnu.org/mailman/listinfo/lwip-users
> >
>
>
>
> _______________________________________________
> lwip-users mailing list
> address@hidden
> http://mail.nongnu.org/mailman/listinfo/lwip-users
>