RE: [lwip-users] small change in tcp/ip initialization

[Taranowski, Thomas \(SWCOE\)]

I think we should remove the parameters if they're not needed, even if
it breaks current ports.  We've already sort of passed the
break-the-port barrier with the lwip_socket_init, which requires user
apps to change.  

Having unused arguments and return value feels too much like legacy code
for my comfort.  New folks looking to port the source will likely waste
time trying to figure out what the heck the unused arguments are for.
Furthermore, the confusion deepens when going to google to look for
implementation hints, and finding older ports that actually use the
values.

 
> -----Original Message-----
> From: address@hidden
> [mailto:address@hidden
On
> Behalf Of Goldschmidt Simon
> Sent: Monday, March 05, 2007 1:32 AM
> To: Mailing list for lwIP users
> Subject: RE: [lwip-users] small change in tcp/ip initialization
> 
> Hi,
> 
> > > My idea was to move the calls to ip_/udp_/tcp_init() from
> > tcpip_thread
> > > () to tcpip_init(). Any objections?
> >
> > This sounds like a good idea.
> 
> Already checked it in. As you could read earlier, Dmitry suggested to
> remove the parameters from tcpip_init() because no feedback on
> initialization is needed any more. I think that would be good,
although
> it breaks all the ports.
> Any comments?
> 
> Simon.
> 
> 
> _______________________________________________
> lwip-users mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/lwip-users