mediagoblin-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2] Remove seemingly unused exception handling from setup.py.


From: Ben Sturmfels
Subject: [PATCH v2] Remove seemingly unused exception handling from setup.py.
Date: Thu, 1 Apr 2021 16:36:00 +1100

Hi Chris,

Do you see any issues with removing the below exception handling in
MediaGoblin's setup.py? The comments are a bit vague as to the
circumstances when this exception handling is relevant.

I've tried installing with the following commands without hitting any
issues:

  `bin/python setup.py install`

and

  `bin/python -m pip install .`

Regards,
Ben

---
 setup.py | 19 ++-----------------
 1 file changed, 2 insertions(+), 17 deletions(-)

diff --git a/setup.py b/setup.py
index 9decc2c1..9b4b5f11 100644
--- a/setup.py
+++ b/setup.py
@@ -86,8 +86,7 @@ extras_require = [
 with open(READMEFILE, encoding="utf-8") as fobj:
     long_description = fobj.read()
 
-try:
-    setup(
+setup(
     name="mediagoblin",
     version=get_version(),
     packages=find_packages(exclude=['ez_setup', 'examples', 'tests']),
@@ -134,18 +133,4 @@ try:
         'Programming Language :: Python :: 3.4',
         "Topic :: Internet :: WWW/HTTP :: Dynamic Content"
         ],
-    )
-except TypeError as e:
-    import sys
-
-    # Check if the problem is caused by the sqlalchemy/setuptools conflict
-    msg_as_str = str(e)
-    if not (msg_as_str == 'dist must be a Distribution instance'):
-        raise
-
-    # If so, tell the user it is OK to just run the script again.
-    print("\n\n---------- NOTE ----------", file=sys.stderr)
-    print("The setup.py command you ran failed.\n", file=sys.stderr)
-    print("It is a known possible failure. Just run it again. It works the "
-          "second time.", file=sys.stderr)
-    sys.exit(1)
+)
-- 
2.30.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]