Re: [Monotone-devel] package_revision.txt getting "unknown" when it shouldn't?

[Nathaniel Smith]

On Mon, Dec 06, 2004 at 11:20:58PM +0100, Richard Levitte - VMS Whacker wrote:
> In message <address@hidden> on Mon, 6 Dec 2004 13:13:13 -0800, Nathaniel 
> Smith <address@hidden> said:
> 
> njs> > The attached change does that.  If noone complains, I'll commit it
> njs> > tomorrow evening.
> njs> 
> njs> Only problem I see is that I'd like some extra message written
> njs> into the --full-version if we were unable to regenerate it at
> njs> build time; right now it can't possibly be stale information
> njs> (unless someone is editing files _while_ building), but in
> njs> principle someone could download a distribution, make some local
> njs> changes, build it, and --full-version would show no sign.
> 
> The only way I can see doing that is to keep a list of hashes
> (basically the old manifest :-)) and compare with a new generation of
> the same.  Or something like that.  It should be external to the
> program itself (like a small utility program), so as not to get any
> circular dependency.  Shouldn't be too hard to do, it's already done
> to check some FIPS signatures in OpenSSL 0.9.7e (in which I'm quite
> involved).

Oh, I don't mean actually checking the revision against the working
copy to verify it's accuracy; I just mean, if we had to fall back on
the stored data during the build, then --full-version should output
something like
  monotone 0.15 (base revision: dafaa04b66bc7366d72ed336a5071e6e17b444a3)
  Changes since base revision:
  
  new_manifest [1d85a387dbb3c7d64a41ec2a6850ec00d19f0f5d]
  
  old_revision [dafaa04b66bc7366d72ed336a5071e6e17b444a3]
  old_manifest [1d85a387dbb3c7d64a41ec2a6850ec00d19f0f5d]

  Generated from cached data; further changes may have been made.
this part ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
(or wording to that effect)

> njs> Also, some comment on what's going on in those build rules would
> njs> be nice, it took me some puzzling to figure it out :-).
> 
> Which one puzzles you?

The cleverness with what's going on with that temporary file, mostly.
Just some note about what the desired goal is would be nice.

-- Nathaniel

-- 
"On arrival in my ward I was immediately served with lunch. `This is
what you ordered yesterday.' I pointed out that I had just arrived,
only to be told: `This is what your bed ordered.'"
  -- Letter to the Editor, The Times, September 2000