[Monotone-devel] revision.cc::find_least_common_ancestor bug, test and patch

[Emile Snyder]

Hi all,

I found what I believe is another very simple bug.  If someone could
look over the attached test and patch I would appreciate it.

If you try to do 'monotone diff ID1 ID2' where ID2 is a direct
descendant of ID1 with no intervening funny business, monotone complains
'monotone: misuse: no common ancestor for ID1 and ID2'  (See attached
test.)

In revision.cc: find_least_common_ancestor (which returns a bool) there
was no code path to return true, but there was a spot which logged the
fact that we did in fact find a common ancestor.  I just inserted a
'return true;' after the logging statement, and it seems to behave
correctly.

thanks,
-emile

+----------------------------------------------------------------------
Pauli's exclusive, Heisenberg's uncertain and Schroedinger just waves --
Caton Little 
+----------------------------------------------------------------------

direct_ancestor.patch
Description: Text document

signature.asc
Description: This is a digitally signed message part