Re: [Monotone-devel] revision.cc::find_least_common_ancestor bug, test and patch

[Emile Snyder]

On Thu, 2004-12-16 at 23:10, Joel Rosdahl wrote:
> Emile Snyder <address@hidden> writes:
> 
> > I found what I believe is another very simple bug. If someone could
> > look over the attached test and patch I would appreciate it.
<snip>
> The missing "return true" is a result of a bug in the merge/diff
> algorithm; the statement is present in
> b8e5eeb7a3e96bd86441e58fc9c7eee760884cbd but removed in
> c853237f9d8d155431f88aca12932d2cdaaa31fe. It's maybe the same bug as

Ah, thanks.  Sure seems likely to be the same bug.  Hopefully anyway.
-emile

> the one t_merge_1.at is reproducing, but I've made a t_merge_2.at with
> this error just in case. Available via netsync at joel.rosdahl.net
> (collection: net.venge.monotone, server key:
> http://joel.rosdahl.net/monotone.key).
> 
>         Joel

+----------------------------------------------------------------------
Beware of bugs in the above code; I have only proved it correct, not
tried it. -- Donald Knuth 
+----------------------------------------------------------------------