Re: [Monotone-devel] binary files merging and hook

[bchiara]

Richard Levitte - VMS Whacker wrote:
> Hi,
>
> I just looked at the recent change that has monotone automagically
> recognise a binary file.  I pretty much like, except for one little
> detail: the lua hook binary_file will default to see a file as
> binary.  I think that's a big mistake.  The last line of the function
> should return false, not true.
Ok, I don't have any objections to change, but I'm curious about why you 
think returning true is a big mistake.
That line should be called only if the file is empty or unreadable, thus 
it seemed safer to me assume it binary.

Ciao,
Riccardo

Ps
Thank you for the doc fix!