Re: [Monotone-devel] binary files merging and hook

[Richard Levitte - VMS Whacker]

In message <address@hidden> on Fri, 10 Jun 2005 07:54:05 +0200, bchiara 
<address@hidden> said:

birrachiara> Ok, I don't have any objections to change, but I'm
birrachiara> curious about why you think returning true is a big
birrachiara> mistake.

Actually, call that an "oops".  I didn't read the function properly.
Seeing that was not the only mistake I did last night, I must have
been quite tired...

birrachiara> That line should be called only if the file is empty or
birrachiara> unreadable, thus it seemed safer to me assume it binary.

At this point, I'm finding it dangerous to make any assumption,
especially if the file is unreadable.  Maybe binary_file would really
need to be tri-state: "yes", "no" and "heck, I've no fscking clue!"
:-)

birrachiara> Ps
birrachiara> Thank you for the doc fix!

YW

Cheers,
Richard

-----
Please consider sponsoring my work on free software.
See http://www.free.lp.se/sponsoring.html for details.

-- 
Richard Levitte                         address@hidden
                                        http://richard.levitte.org/

"When I became a man I put away childish things, including
 the fear of childishness and the desire to be very grown up."
                                                -- C.S. Lewis