[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] Performance accounting and testing patch
From: |
Nathaniel Smith |
Subject: |
Re: [Monotone-devel] Performance accounting and testing patch |
Date: |
Wed, 10 Aug 2005 21:43:58 -0700 |
User-agent: |
Mutt/1.5.9i |
On Wed, Aug 10, 2005 at 01:02:15AM -0700, Eric Anderson wrote:
> The accounting stuff is OS specific, it would probably compile but not
> work on a non-linux Unix platform, and may not compile on
> Windows. There is probably equivalent functionality on all the other
> platforms, but unfortunately resource usage is not one of the
> interfaces that has been standardized.
>
> It is easy enough to modify the patch to have ifdefs for linux around
> it if people would like me to make that change. I can also move it to
> a separate file if someone would suggest an appropriate name.
Getting these numbers seems useful.
But, it definitely looks like, if I were to apply this patch as is, we
would immediately stop building on windows. Which would probably
cause complaints, it being a fully-supported platform and all.
What if we add some instrumentation hooks to platform.hh? platform.hh
is prototypes for various functions that are implemented in either
unix/*.cc or win32/*.cc; if functionality is not (yet) supported on
some platform, you can just stub in a no-op implementation.
There's already a hook called at the beginning/end of netsync (that
disables SIGPIPE on posix); could just have another one called at
beginning/end of program run?
-- Nathaniel
--
Damn the Solar System. Bad light; planets too distant; pestered with
comets; feeble contrivance; could make a better one myself.
-- Lord Jeffrey