[Monotone-devel] Re: [PATCH] monotone ls authors

[Bruce Stephens]

"Steven E. Harris" <address@hidden> writes:

> Bruce Stephens <address@hidden> writes:
>
>> +  for (vector< revision<cert> >::const_iterator i = certs.begin();
>> +       i != certs.end(); ++i)
>
> Why keep checking against an end that doesn't change?
>
>   for (vector< revision<cert> >::const_iterator i = certs.begin(),
>                                                 end = certs.end();
>        i != end; ++i)

Well, because it was copy and paste from ls_tags.  However, I'd hope
the compiler would notice that certs isn't changing in the loop
(certs.end() is presumably const), so it wouldn't make any difference.
So it's a question of style as much as anything.  I don't care much
either way.

>> +  for (std::set< cert_value >::const_iterator i = authors.begin();
>> +       i != authors.end(); ++i)
> +    {
> +      cout << *i << endl;
> +    }
>
> How about std::copy to std::ostream_iterator?

[...]

>   std::copy( authors.begin(), authors.end(),
>              std::ostream_iterator<cret_value>( std::cout, "\n" ) );

That's definitely nicer, though.  (I prefer it, anyway.)