Re: [Monotone-devel] [ANNOUNCE] monotone 0.26pre3 released

[Petr Ovtchenkov]

On Thursday 30 March 2006 04:38, Nathaniel Smith wrote:
> The monotone team is happy to announce the release of monotone
> 0.26pre3, available at the usual places:
>   http://venge.net/monotone
>   http://venge.net/monotone/downloads/monotone-0.26pre3.tar.gz
> 
> This should be the last pre-release before 0.26, and is considered to
> be feature complete.  All that remains for 0.26 is writing some tests
> and investigating some bug reports.
> 
> _Please_ test this release, and sooner is better than later.  There
> are some very important changes compared to 0.26pre2, and it's
> possible 0.26 will match this release almost exactly.
> 
> NEWS entry for this release:
> 
> Wed Mar 29 05:20:10 PST 2006
> 
>         0.26pre3 release.  This release may be considered a "release
>         candidate", in that while we need to write some tests and make
>         sure some bugs are fixed, all features are in and we hope that
>         no further bug fixes will be needed either.  It is still a
>         pre-release for testing.  Do not package it.  DO NOT USE THIS
>         RELEASE UNLESS YOU WANT TO BE A DAREDEVIL.
> 
>         But, PLEASE PLEASE TEST this release.  There are some
>         non-trivial changes since 0.26pre2, and this is your last
>         chance!

BTW,

> diff -u monotone-0.26pre3/xdelta.cc monotone-0.26pre3.new/xdelta.cc
--- monotone-0.26pre3/xdelta.cc Wed Mar 29 16:32:56 2006
+++ monotone-0.26pre3.new/xdelta.cc     Fri Mar 31 00:23:57 2006
@@ -119,9 +119,9 @@
   string::const_iterator bi = b.begin() + bpos + tlen;
   string::const_iterator be = b.end();

-  while((*ai == *bi)
-       && (ai != ae)
-       && (bi != be))
+  while((ai != ae)
+       && (bi != be)
+        && (*ai == *bi))
     {
       ++tlen;
       ++ai;

Comment: dereference of string's iterator happens for a.end() and/or b.end();
thanks for STLport's debug mode.

Bests,

   - Petr