[Monotone-devel] Usher crashes

[Jeronimo Pellegrini]

Hi.
I just compiled usher, and started it:

$ ./usher -m "mtn -kmy_key" -a 127.0.0.1:10000 usher.cfg 

usher.cfg has the following:

================
userpass "jp" "no_I_wont_tell_you"

server "phd"
host "localhost"
pattern "info.aleph0.phd*"
local "-d" "/home/jeronimo/monotone/phd.db"

server "main"
host "localhost"
pattern "info.aleph0.*"
local "-d" "/home/jeronimo/monotone/main.db"
=================

I hope that matching first "info.aleph0.phd*" and later "info.aleph0.*"
is not a problem...

OK, so I did:

=================
$ telnet localhost 10000
Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.
LIST
main phd
Connection closed by foreign host.

$ telnet localhost 10000
Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.
STATUS main
SLEEPING
Connection closed by foreign host.
==================

OK, everything is there, and usher is running.

Now, from another host:

==================
$ mtn push rumi
mtn: connecting to rumi
mtn: error: I/O failure while talking to peer rumi, disconnecting
==================

And at rumi, who is running usher:

==================
Segmentation fault
==================

I ran usher under gdb (the same command line options were passed), and got this:

=================
Program received signal SIGSEGV, Segmentation fault.
server_manager::prefix::cmp (this=0xbfffeffc, address@hidden) at 
basic_string.h:269
269           { return &((reinterpret_cast<_Rep*> (_M_data()))[-1]); }
(gdb) where
#0  server_manager::prefix::cmp (this=0xbfffeffc, address@hidden) at 
basic_string.h:269
#1  0x0805cee3 in server_manager::prefix::operator== (this=0xbfffeffc, 
address@hidden) at server_manager.cc:55
#2  0x0806041f in server_manager::connect_to_server (this=0xbfffefd0, 
address@hidden, address@hidden) at stl_tree.h:176
#3  0x08056421 in channel::process_selected (this=0x8081810, address@hidden, 
address@hidden, address@hidden) at channel.cc:101
#4  0x080675a9 in main (argc=6, argv=0x8081808) at stl_list.h:135
==================

Also, I noticed that usher will start and pretend that everything is OK,
even if one of the local databases does not exist. Maybe the server
could exit with an error, or at least issue a warning?

Thanks,
J.