monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Usher pattern matching (was Re: [Monotone-devel] Usher crashes)


From: Jeronimo Pellegrini
Subject: Usher pattern matching (was Re: [Monotone-devel] Usher crashes)
Date: Sat, 13 May 2006 23:29:31 -0300
User-agent: Mutt/1.5.11+cvs20060403

OK, I'll compile the problems I found before:

> If I use:

> server "main"
> host "localhost"
> pattern "info.aleph0"
> local "-d" "/home/jeronimo/monotone/main.db" "*"

> And try to sync brahch   info.aleph0.my_branch

It won't work.

> Neither if I try:
> pattern "info.aleph0.*"

> But if I use:
> pattern "info.aleph0.my_branch"

It works, but only if I fix line 185 of server_manager::connect_to_server
where it  matches pattern against host:

if (!srv && !pattern.empty() && !by_pattern.empty())
    {
      i = by_pattern.lower_bound(pattern);
      if (i != by_pattern.end() && i->first == prefix(host))
                                                      ^^^^

And even if I try to make it match against pattern, it fails,
because of the way operator== works for struct prefix. Is this
intentional? Shouldn't it also do partial matches?

J.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]