[Monotone-devel] revert --missing misbehaves in 0.26

[Jack Lloyd]

Montone's revert --missing seems to base paths off the current
directory, rather than the base directory of the workspace. I think
most people seeing this would realize the problem and self-correct,
but it is strange (drop --missing seems to do the right thing and work
no matter what the cwd is). I suppose in some extremely contorted case
this could cause Monotone to revert the wrong file, as well. Based on
the documentation this behaviour seems unintentional, and performing
revert --missing from a subdirectory of a workspace should revert all
missing files in or below that subdir.

Reproducing is fairly simple, drop a file from one workspace,
commit+sync, rm (without dropping) the same file in another workspace,
and then update.

(washu ~/testing/2nd/a/b/c)$ mtn stat
mtn: warning: missing a/b/c/d1
mtn: misuse: 1 missing files; use 'mtn ls missing' to view
mtn: misuse: to restore consistency, on each missing file run either
mtn: misuse: 'mtn drop FILE' to remove it permanently, or
mtn: misuse: 'mtn revert FILE' to restore it
mtn: misuse: or to handle all at once, simply 'monotone drop --missing'
mtn: misuse: or 'monotone revert --missing'
(washu ~/testing/2nd/a/b/c)$ mtn ls missing
a/b/c/d1
(washu ~/testing/2nd/a/b/c)$ mtn revert --missing
mtn: misuse: unknown path 'a/b/c/a/b/c/d1'
(washu ~/testing/2nd/a/b/c)$ mtn revert --missing .
mtn: misuse: unknown path 'a/b/c/a/b/c/d1'
(washu ~/testing/2nd/a/b/c)$ cd ..
(washu ~/testing/2nd/a/b)$ mtn revert --missing
mtn: misuse: unknown path 'a/b/a/b/c/d1'
(washu ~/testing/2nd/a/b)$ cd ..
(washu ~/testing/2nd/a)$ mtn revert --missing
mtn: misuse: unknown path 'a/a/b/c/d1'
(washu ~/testing/2nd/a)$ cd ..
(washu ~/testing/2nd)$ mtn revert --missing
(washu ~/testing/2nd)$

Also the messages need to be updated to the new binary name. :)

System info:

(washu ~)$ mtn --version
monotone 0.26 (base revision: 4342565107f26ceda955b66c66b5b7ec152f314e)
(washu ~)$ uname -a
Linux washu.randomint.net 2.6.16-1.2111_FC4 #1 Sat May 20 19:59:40 EDT 2006 
i686 athlon i386 GNU/Linux
(washu ~)$ gcc -v
Using built-in specs.
Target: i386-redhat-linux
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man 
--infodir=/usr/share/info --enable-shared --enable-threads=posix 
--enable-checking=release --with-system-zlib --enable-__cxa_atexit 
--disable-libunwind-exceptions --enable-libgcj-multifile 
--enable-languages=c,c++,objc,java,f95,ada --enable-java-awt=gtk 
--with-java-home=/usr/lib/jvm/java-1.4.2-gcj-1.4.2.0/jre 
--host=i386-redhat-linux
Thread model: posix
gcc version 4.0.2 20051125 (Red Hat 4.0.2-8)
(washu ~)$ rpm -q glibc boost
glibc-2.3.6-3
boost-1.32.0-6

If you need further information just let me know.

-Jack