Re: [Monotone-devel] cvs_import and timezones

[Zack Weinberg]

On 10/2/06, Tony Tung <address@hidden> wrote:
> It seems tzset() is never called.  Without that, the environment
> variable TZ is never processed.  I put it in cvs_commit::cvs_commit
> (rcs_file const & r, string const & rcs_version, file_id const &
> ident, cvs_history & cvs) just to test it, and it behaves correctly.

Uh, what??? It should not be necessary to call tzset() by hand; libc
does it automatically on the first use of a function that needs time
zone info, e.g. localtime().

> Since we don't want to actually do that every single time cvs_commit
> (...) is called, where would be a good place to call tzset()?

... Is it perhaps that we are using hand-rolled time conversion
functions that don't rely on the libc primitives, but do rely on the
zoneinfo database?  If so _those_ should call tzset().

zw