[Monotone-devel] disapprove and kill_rev_locally do not interact well

[Daniel THOMPSON]

Hi Folks

The following is a distillation of problems I have been having after
some inadvisable disapprovals which I tried to use kill_rev_locally to
resolve...

butch$ mtn db init --db=foo.db
butch$ mkdir bar
butch$ cd bar/
butch$ mtn setup --db=../foo.db --branch=com.st.foo.bar
butch$ echo mary > teepipe
butch$ mtn add teepipe
mtn: adding teepipe to workspace manifest
butch$ mtn commit --message "Started a nursary rhyme"
mtn: beginning commit on branch 'com.st.foo.bar'
mtn: committed revision 208d6ab45de22e5070fbbbbd8d5ae9a3ffa5f0b8
butch$ echo had >> teepipe
butch$ mtn commit --message "More rhymes"
mtn: beginning commit on branch 'com.st.foo.bar'
mtn: committed revision 5e3ed308ba211627cf19fe54343708dfcee93c16
butch$ echo a >> teepipe
butch$ mtn commit --message "Guess what?"
mtn: beginning commit on branch 'com.st.foo.bar'
mtn: committed revision 35634f3ea785e203a874fc0682142f385d916e2c
butch$ mtn disapprove 5e3ed308ba211627cf19fe54343708dfcee93c16
butch$ mtn heads
mtn: branch 'com.st.foo.bar' is currently unmerged:
35634f3ea785e203a874fc0682142f385d916e2c address@hidden
2007-01-17T13:54:34
a72cd0c3b1d8ea7d9b07afa249c9a00b2fdbb68f address@hidden
2007-01-17T13:54:41
butch$ mtn db kill_rev_locally a72cd0c3b1d8ea7d9b07afa249c9a00b2fdbb68f
butch$ mtn heads
mtn: branch 'com.st.foo.bar' is currently merged:
35634f3ea785e203a874fc0682142f385d916e2c address@hidden
2007-01-17T13:54:34
butch$ mtn update
mtn: updating along branch 'com.st.foo.bar'
mtn: already up to date at 35634f3ea785e203a874fc0682142f385d916e2c
butch$ mtn disapprove 5e3ed308ba211627cf19fe54343708dfcee93c16
terminate called after throwing an instance of 'std::logic_error'
  what():  lru_writeback_cache.hh:99: invariant 'I(_dirty.empty())' violated
mtn: fatal signal: Aborted
this is almost certainly a bug in monotone.
please send this error message, the output of 'mtn --full-version',
and a description of what you were doing to address@hidden
do not send a core dump, but if you have one,
please preserve it in case we ask you for information from it.
Aborted
butch$ mtn --full-version
monotone 0.32 (base revision: 3f0fa5c1d232d37d47f6436fe74919dd3cd003b1)
Running on          : Linux 2.6.18-1.2257.fc5smp #1 SMP Fri Dec 15
16:33:51 EST 2006 i686
C++ compiler        : GNU C++ version 4.1.1 20060525 (Red Hat 4.1.1-1)
C++ standard library: GNU libstdc++ version 20060525
Boost version       : 1_33_1
Changes since base revision:
unknown

Noting that the fault was in lru_writeback_cache.hh I tried 'db
regenerate_caches' on a whim. I was quite chuffed when this actually
resolved the problem!

An interesting bug but not, I suspect, a really important one.

-- 
Daniel Thompson (STMicroelectronics) <address@hidden>
1000 Aztec West, Almondsbury, Bristol, BS32 4SQ. 01454 462659

If a car is a horseless carriage then is a motorcycle a horseless horse?