Re: [Monotone-devel] Tiny improvements to bash_completion

[Matthew Sackman]

On Fri, Feb 23, 2007 at 02:49:45AM -0800, Nathaniel Smith wrote:
> On Thu, Feb 22, 2007 at 02:43:17PM +0000, Matthew Sackman wrote:
> > Wow, that was quick. Thus I feel compelled to do more! Attached is a
> > further patch, which should be applied after yesterday's patch. It now
> > makes bash completions fully support a: b: h: i: and t: selectors on
> > their own and as composites.
> 
> Applied, I think... there was a hunk rejected, for no reason I could
> see (maybe whitespace differences or something?), and I think I fixed
> it up by hand, but you might want to check.

Yeah, it's gone wrong. Lines 171 and 172 should not exist. 'source'-ing
the file in bash currently gives errors. Take lines 171 and 172 out and
all is well.

> For future patches, could you not mangle the filenames being patched?
> I had to edit the diff header so patch would know what file to patch.

Damn, so sorry. I've been using monotone for a while - so slightly rusty
on this whole diff and patch business!

> Alternatively, if you're planning to make more such patches, want to
> send me a key so we can skip the diff/patch thing altogether? :-)

Done.

Matthew