Re: [Monotone-devel] [PATCH] Make --execute default

[William Uther]

On 27/02/2007, at 8:53 PM, William Uther wrote:

> On 27/02/2007, at 6:29 PM, Zack Weinberg wrote:
>
> > What about a file that exists and has just been "add"ed, so it is
> > technically under version control but no version exists in the
> > database yet?  [Suggest warning, dropping it from the manifest but  
> > not
> > deleting the file.  This is the natural (IMO) way to recover from
> > accidentally adding a file that shouldn't have been added.]
>
> Ugh.  The current code deletes the file.  I agree it should be  
> dropped but not deleted.
>
> > Same question as above. [for directories]
>
> Same answer as above.  Sigh.

Okie.  I fixed these in rev 0308fa86bc76702130aeeb5db41405fda591bf75 .

I'm not sure about the code though.  Are node_id's supposed to be  
invariant across the rosters from different revisions?  So if I ask  
if parent_roster.has_node(node_id_from_child), do I get a meaningful  
answer?  (This is how I'm detecting adds - something that isn't in  
any parent roster must have been added.)

Unit tests to come...

Will        :-}