Re: [Monotone-devel] unhexification of revision hashes

[Markus Schiltknecht]

Hi,

Zack Weinberg wrote:
> I haven't looked at the code yet, but I suspect it is because IDs are
> now binary in the database but hexadecimal everywhere else in memory.
> Thus, we are converting from binary to hex all over the place, which
> hurts.

Uh.. obviously you also got that mail, so I'm taking back all I said 
about "reply-to-all" and such... sorry for the noise.

> It *should* be possible to avoid doing that almost everywhere and get
> back the speed.  However, the "almost" is important; the textual
> representation of revisions, rosters, and changesets has hex IDs in
> it. It might be that that alone costs so much performance that we're
> hosed.

Yeah, I have hoped that the 10% saving in I/O bandwidth and OS caches 
would easily be worth the CPU power for hex conversions.

> Markus - how infeasible would it be to change in-memory *_id from hex
> to binary before merging this revision?

I dunno, but I can give it a try tomorrow.

Regards

Markus