Re: [Monotone-devel] [PATCH] fix default .mtn-ignore list

[Zack Weinberg]

I don't think that adjustment does what you meant it to.  The leading
% escapes the period - without it, it's a pseudo-regex wildcard.  (See
http://www.lua.org/manual/5.1/manual.html#5.4.1 ) The dir_matches
function is supposed to treat each of those strings as a full
directory name, not as a partial -- in other words, it's already
supposed not to ignore "foo.svn".  If that's not working, it should be
fixed there.

zw

On Sat, Jul 5, 2008 at 2:47 AM, Ralf S. Engelschall
<address@hidden> wrote:
> The default directory patterns for .mtn-ignore also ignore paths like
> "foo.svn" although Subversion does only use ".svn" (no prefix) for
> its control directory. The same applies for all other VCS and their
> control dirs and GNU Libtool's .deps, etc. So, any objections to this
> adjustment?
>
> Index: std_hooks.lua
> --- std_hooks.lua       f70deee23a8637fbc54f7eddd5275165258b103e
> +++ std_hooks.lua       2e64f1a702db96cc5d3708576a1a610db25a688d
> @@ -173,11 +173,11 @@ function ignore_file(name)
>
>    local dir_pats = {
>       -- autotools detritus:
> -      "autom4te%.cache", "%.deps", "%.libs",
> +      "autom4te%.cache", ".deps", ".libs",
>       -- Cons/SCons detritus:
>       "%.consign", "%.sconsign",
>       -- other VCSes (where metadata is stored in named dirs):
> -      "CVS", "%.svn", "SCCS", "_darcs", "%.cdv", "%.git", "%.bzr", "%.hg"
> +      "CVS", ".svn", "SCCS", "_darcs", ".cdv", ".git", ".bzr", ".hg"
>    }
>
>    for _, pat in ipairs(file_pats) do
>
>                                       Ralf S. Engelschall
>                                       address@hidden
>                                       www.engelschall.com
>
>
>
> _______________________________________________
> Monotone-devel mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/monotone-devel
>